Skip to content

feat(sveltekit): Serve the managed tunnel from sentryHandle under the app's base path - #25415

Open
logaretm wants to merge 10 commits into
awad/tunnel-cloudflarefrom
awad/tunnel-sveltekit
Open

feat(sveltekit): Serve the managed tunnel from sentryHandle under the app's base path#25415
logaretm wants to merge 10 commits into
awad/tunnel-cloudflarefrom
awad/tunnel-sveltekit

Conversation

@logaretm

@logaretm logaretm commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Implements sveltekit tunnel wiring, the way it works is:

  • Our Vite plugin injects the base path if it exists to both server/client bundles.
  • Our entry handler will check for any incoming request if it is a tunneled one, and if it matches it handles it.

(I made the decision to respect base paths rather than ignoring them, this is something to review in #25199)

closes #20256

@logaretm
logaretm added this pull request to stack #25201 October 15, 2026 15:33
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch 2 times, most recently from 364f99c to b6212f2 Compare October 15, 2026 15:36
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 30.53 kB +2.18% +649 B 🔺
@sentry/browser - with treeshaking flags 28.51 kB +1.75% +490 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 28.39 kB +1.7% +473 B 🔺
@sentry/browser (incl. Tracing) 52.77 kB +1.35% +699 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.77 kB +1.35% +698 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.74 kB +1.32% +721 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.44 kB +0.68% +616 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.18 kB +0.62% +496 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.18 kB +0.66% +629 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.17 kB +0.63% +683 B 🔺
@sentry/browser (incl. Feedback) 48.09 kB +1.48% +699 B 🔺
@sentry/browser (incl. sendFeedback) 35.6 kB +1.9% +662 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.73 kB +1.71% +683 B 🔺
@sentry/browser (incl. Metrics) 31.54 kB +2.05% +633 B 🔺
@sentry/browser (incl. Logs) 31.81 kB +2.01% +626 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.48 kB +2.11% +670 B 🔺
@sentry/react 32.33 kB +2% +631 B 🔺
@sentry/react (incl. Tracing) 55.02 kB +1.17% +633 B 🔺
@sentry/vue 38.68 kB +1.7% +643 B 🔺
@sentry/vue (incl. Tracing) 55.72 kB +1.31% +716 B 🔺
@sentry/svelte 30.56 kB +2.2% +657 B 🔺
@sentry/remix (Remix 3 client bundle) 57.8 kB +1.26% +715 B 🔺
CDN Bundle 32.11 kB +1.49% +470 B 🔺
CDN Bundle (incl. Tracing) 53.06 kB +0.91% +478 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.31 kB +1.41% +474 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 55.01 kB +0.89% +483 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 75.26 kB +0.66% +492 B 🔺
CDN Bundle (incl. Tracing, Replay) 90.73 kB +0.53% +478 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.66 kB +0.52% +479 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 96.87 kB +0.49% +468 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.83 kB +0.5% +489 B 🔺
CDN Bundle - uncompressed 94.33 kB +1.24% +1.15 kB 🔺
CDN Bundle (incl. Tracing) - uncompressed 157.19 kB +0.74% +1.15 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.87 kB +1.16% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.14 kB +0.72% +1.15 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 230.91 kB +0.51% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 277.35 kB +0.42% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.3 kB +0.41% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 291.06 kB +0.4% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 296.99 kB +0.39% +1.15 kB 🔺
@sentry/nextjs (client) 57.45 kB +1.08% +613 B 🔺
@sentry/sveltekit (client) 53.26 kB +1.54% +806 B 🔺
@sentry/core/server 42.85 kB +4.18% +1.72 kB 🔺
@sentry/core/browser 13.81 kB - -
@sentry/node 155.81 kB +0.47% +719 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 84.06 kB - -
@sentry/node - without tracing 97.48 kB +0.73% +701 B 🔺
@sentry/node - without channel injection 133.81 kB +0.52% +691 B 🔺
@sentry/aws-serverless 105.75 kB +0.78% +816 B 🔺
@sentry/cloudflare (withSentry) - minified 212.9 kB +0.96% +2.01 kB 🔺
@sentry/cloudflare (withSentry) 528.07 kB +0.94% +4.9 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 230.58 kB +0.89% +2.01 kB 🔺

View base workflow run

@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch 2 times, most recently from de28310 to 47c1f76 Compare October 15, 2026 16:20
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 47c1f76 to d1a7e32 Compare October 15, 2026 16:38
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from d1a7e32 to 17f5b0c Compare October 15, 2026 17:15
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 17f5b0c to ff9f3cc Compare October 15, 2026 17:36
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch 2 times, most recently from 7185904 to 0846a80 Compare October 15, 2026 18:16
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 0846a80 to 2d31aba Compare October 15, 2026 18:26
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 2d31aba to d7b1800 Compare October 15, 2026 18:28
@logaretm

logaretm commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

bugbot run

cursor[bot]
cursor Bot reviewed Oct 15, 2026
View reviewed changes

@cursor cursor Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread packages/sveltekit/test/vite/tunnelBasePath.test.ts
Comment thread dev-packages/e2e-tests/test-applications/sveltekit-3/tests/tunnel.test.ts Outdated
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from d7b1800 to 1d49365 Compare October 16, 2026 01:51
@logaretm

logaretm commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

bugbot run

cursor[bot]
cursor Bot reviewed Oct 16, 2026
View reviewed changes

@cursor cursor Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread packages/sveltekit/src/vite/tunnelBasePath.ts Outdated
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 1d49365 to 89e93d5 Compare October 16, 2026 02:25
@logaretm

logaretm commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch 3 times, most recently from d0e1a76 to 05c691a Compare October 19, 2026 18:36
@logaretm
logaretm force-pushed the awad/tunnel-sveltekit branch from 05c691a to 36f589a Compare October 19, 2026 19:12
@logaretm
logaretm marked this pull request as ready for review October 19, 2026 19:36
@logaretm
logaretm requested a review from a team as a code owner October 19, 2026 19:36
@logaretm
logaretm requested review from chargome and s1gr1d and removed request for a team October 19, 2026 19:36
cursor[bot]
cursor Bot reviewed Oct 19, 2026
View reviewed changes

@cursor cursor Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread dev-packages/e2e-tests/test-applications/sveltekit-3/tests/tunnel.test.ts Outdated
Comment thread dev-packages/e2e-tests/test-applications/sveltekit-3/tests/tunnel.test.ts Outdated
Comment thread packages/sveltekit/src/vite/tunnelBasePath.ts Outdated
logaretm added 10 commits October 19, 2026 16:05
@logaretm
feat(sveltekit): Serve the managed tunnel from sentryHandle under t…
1fc91a1 
…he app's base path

`sentryHandle` answers tunnel requests before isolation, tracing and routing.
`sentrySvelteKit()` hands `paths.base` to the client and server SDKs, so
`tunnel: true` works under a base path without repeating it.
@logaretm
fix(sveltekit): Keep source maps of the hooks files under a base path
c97becb
@logaretm
fix(sveltekit): Serve a relative tunnel path under the base path too
00cef96
@logaretm
test(sveltekit): Check the managed tunnel under vite dev too
22a2be0
@logaretm
test(sveltekit): Check no span of a tunnel request is sent with Kit t…
594c46a 
…racing on
@logaretm
ref(sveltekit): Import the tunnel handler from @sentry/core/server
a66dae5
@logaretm
test(sveltekit): Send Content-Length with the tunnel test requests
03782ad 
The tunnel handler now answers a request without one with a 411.
@logaretm
test(sveltekit): Race the tunnel span with a shared test-utils helper…
a4fb042 
…, in one test per app
@logaretm
ref(sveltekit): Let core skip an empty base path, and keep only the t…
51947f5 
…ests of what the SDK adds
@logaretm
fix(sveltekit): Keep the base path module when tree-shaking treats mo…
5cbcc07 
…dules as side-effect free
@logaretm
logaretm requested review from a team as code owners October 19, 2026 20:07
@logaretm
logaretm requested review from JPeer264 and isaacs and removed request for a team October 19, 2026 20:08
cursor[bot]
cursor Bot reviewed Oct 19, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5cbcc07. Configure here.

Comment thread dev-packages/test-utils/src/tunnel.ts
return span => {
const urlPath = String(span.attributes['url.path']?.value ?? '');

return getSpanOp(span) === 'http.server' && (typeof path === 'string' ? urlPath === path : path.test(urlPath));

@cursor cursor Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded span ops in tests

Low Severity

New tests assert 'url.path', 'http.server', and 'pageload' as string literals. The review rules require @sentry/conventions constants (URL_PATH, HTTP_SERVER, and the pageload op) in test assertions as well as SDK source, so these checks drift if the constants change. Flagged because it was mentioned in the review rules file.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5cbcc07. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@chargome chargome Awaiting requested review from chargome chargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@isaacs isaacs Awaiting requested review from isaacs isaacs was automatically assigned from getsentry/team-javascript-sdks-server
@JPeer264 JPeer264 Awaiting requested review from JPeer264 JPeer264 was automatically assigned from getsentry/team-javascript-sdks-server
@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-javascript-sdks-browser
@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-javascript-sdks-browser

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SvelteKit tunnel adapter

1 participant

@logaretm